Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Caching #3168

Merged
merged 31 commits into from
Jan 29, 2021
Merged

API Caching #3168

merged 31 commits into from
Jan 29, 2021

Conversation

jesseleite
Copy link
Member

@jesseleite jesseleite commented Jan 27, 2021 •
edited by jasonvarga
Loading

Adds API caching. Closes statamic/ideas#292.

Closes #2923

jesseleite and others added 26 commits January 27, 2021 11:53
@jesseleite
Add default API caching config.
3faeb6a
@jesseleite
Move API service provider into new API namespace.
6cd38e2
@jesseleite
Add basic API cache manager.
23aa6d9
@jesseleite
Add basic Cacher interface.
53e04d8
@jesseleite
Add dummy NullCacher.
c6186b8
@jesseleite
Implement basic DefaultCacher, with extendable AbstractCacher class.
8013043
@jesseleite
Bind API cache manager.
a115596
@jesseleite
Cache collection entries API endpoints.
580f785
@jesseleite
Fix UserSaved event firing before setting initial button options.
83b35e3
@jesseleite
Extract content events prop for reuse.
a83b06f
@jesseleite
Add subcriber for handling event-based API cache invalidation.
d7347c0
@jesseleite
Handle API cache validation events.
400082c
@jesseleite
Merge branch 'master' of https://github.com/statamic/cms into feature…
f277a46 
…/api-caching
@jesseleite
Not passing in cache repository instance at the moment.
6d97fba
@jesseleite
Cleanup.
d26a6b5
@jesseleite
Add basic API Cacher test case.
e12f5e8
@jesseleite
Test configured expiry.
cef1593
@jesseleite
Ensure default API cacher converts resources to responses.
2fe8253
@jesseleite
Move response helper to parent API\AbstractCacher.
c3bb9be
@jesseleite
Reverting.
49adf88
@jasonvarga
Use wrapper method for getting the response
237543c
@jesseleite
Extract helper for getting common query params.
05a54a6
@jesseleite
We already have the request here.
e777ae4
@jesseleite
Docblock.
1c917b9
@jesseleite
Wrap all API endpoints withCache().
5e0569e
@jesseleite
Pass tests again.
1b1c508 
Since our controllers are constructed with a request, testing multiple endpoints in a single test method will only use the first request.
@jesseleite jesseleite requested a review from jasonvarga January 28, 2021 23:24
@jesseleite
Avoid injecting request into controllers.
87356b2 
This makes it harder to test multiple endpoints in an orchest test, as only the first request will be used when the router instantiates controllers.
@jesseleite jesseleite marked this pull request as ready for review January 29, 2021 16:05
@jasonvarga
Copy link
Member

Looks like you also fixed #2923

@jasonvarga jasonvarga merged commit 740610e into master Jan 29, 2021
@jesseleite jesseleite deleted the feature/api-caching branch January 29, 2021 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonvarga jasonvarga Awaiting requested review from jasonvarga

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jesseleite @jasonvarga